[PATCH] D42322: [WebAssembly] Remove custom handling for undefined entry. NFC

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 19 16:55:20 PST 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rLLD323020: [WebAssembly] Remove custom handling for undefined entry (authored by sbc, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D42322?vs=130703&id=130726#toc

Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42322

Files:
  test/wasm/undefined-entry.test
  wasm/Driver.cpp


Index: test/wasm/undefined-entry.test
===================================================================
--- test/wasm/undefined-entry.test
+++ test/wasm/undefined-entry.test
@@ -2,3 +2,9 @@
 RUN: not lld -flavor wasm -o %t.wasm %t.ret32.o 2>&1 | FileCheck %s
 
 CHECK: error: undefined symbol: _start
+
+RUN: not lld -flavor wasm -entry=foo -o %t.wasm %t.ret32.o 2>&1 | FileCheck %s -check-prefix=CHECK-CUSTOM
+
+CHECK-CUSTOM: error: undefined symbol: foo
+
+RUN: lld -flavor wasm -entry=foo --allow-undefined -o %t.wasm %t.ret32.o
Index: wasm/Driver.cpp
===================================================================
--- wasm/Driver.cpp
+++ wasm/Driver.cpp
@@ -349,8 +349,6 @@
       Sym->setHidden(false);
   }
 
-  if (!Config->Entry.empty() && !Symtab->find(Config->Entry)->isDefined())
-    error("entry point not found: " + Config->Entry);
   if (errorCount())
     return;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42322.130726.patch
Type: text/x-patch
Size: 889 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180120/e43f089c/attachment.bin>


More information about the llvm-commits mailing list