[PATCH] D42321: [WebAssembly] Remove special handling of entry point export. NFC

[Nicholas Wilson via Phabricator via llvm-commits]

ncw accepted this revision.
ncw added a comment.
This revision is now accepted and ready to land.

You've removed the check for `CtorSymbol == EntrySym`, I guess because you can't think of a reason why anyone would want to do `--entry=__wasm_init_ctors`? But if we do ever make the entry-point be treated as the "start" function, then that might be what we want.

This is good, because it gives `--entry` a clear reason to exist, but maybe it's not generic enough. Apart for the setHidden(false) call, is `--entry` identical to `--export`? So really `--entry` is redundant now, maybe it should actually go away.

Go ahead though and merge, I'm just musing here.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42321