[PATCH] D42306: [WebAssembly] Symbol changes #4d: export import flags, LLD only

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added a comment.

In https://reviews.llvm.org/D42306#982316, @sbc100 wrote:

> Neither of those two tests seems to pass now.
>
> Perhaps because I'm trying to apply this to HEAD?


Ah yes, I could fix that if you want to apply it before #2 and #3 - I probably should have done that anyway since #4a and #4b were already merged, sorry.



================
Comment at: wasm/Writer.cpp:389
   std::vector<std::pair<StringRef, uint32_t>> SymbolInfo;
-  for (const WasmExportEntry &E : ExportedSymbols) {
+  auto addSymInfo = [&](const Symbol *Sym, StringRef ExternalName) {
     uint32_t Flags =
----------------
sbc100 wrote:
> I think this should follow the CamelCase convention for local variables (at least that is what others seems to do in lld).
Oops, I renamed it following some code I saw elsewhere. I checked the LLVM style guide and it didn't say what to do for lambdas - are they lowercase as functions, or uppercase as variables?

I see about 50/50 looking at the first 20 grep results for `\[&\]`, so I guess it doesn't matter.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42306