[PATCH] D42312: [ARM] Cleanup part of ARMBaseInstrInfo::optimizeCompareInstr (NFCI).
    Eli Friedman via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Jan 19 13:06:04 PST 2018
    
    
  
efriedma added inline comments.
================
Comment at: lib/Target/ARM/ARMBaseInstrInfo.cpp:2754
+    if ((Instr.modifiesRegister(ARM::CPSR, TRI) ||
+         Instr.readsRegister(ARM::CPSR, TRI)) && I != E)
       // This instruction modifies or uses CPSR after the one we want to
----------------
Maybe it would be more clear to write "if (I == E) break;" before this check?
https://reviews.llvm.org/D42312
    
    
More information about the llvm-commits
mailing list