[PATCH] D42235: [AArch64] Avoid unnecessary vector byte-swapping in big-endian
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 19 11:24:29 PST 2018
efriedma added inline comments.
================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:726
+ MVT PromoteTo = MVT::INVALID_SIMPLE_VALUE_TYPE;
+ switch (VT.SimpleTy) {
+ case MVT::v2f32:
----------------
Could you use changeVectorElementTypeToInteger or something like that rather than listing out all the types individually?
================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:743
+ default:
+ IsPromotedFloatVector = false;
+ }
----------------
Missing break.
Repository:
rL LLVM
https://reviews.llvm.org/D42235
More information about the llvm-commits
mailing list