[PATCH] D42117: [WebAssembly] Symbol changes #6: syminfo index, LLVM

Fri Jan 19 11:01:32 PST 2018

ncw added a comment.

In https://reviews.llvm.org/D42117#982151, @sbc100 wrote:

> In https://reviews.llvm.org/D42117#982103, @ncw wrote:
>
> > Updates:
> >
> > - Rebased
> > - Removed `std::sort()` of the symbol flags, that wasn't actually doing anything useful since obj2yaml reorders them anyway
>
>
> Hmm.. obj2yaml is sorting stuff ?  I don't think it should since its supposed to mirror the binary directly.

Not exactly - obj2yaml is using the canonical order from the Wasm file, but it's using the order the symbol are declared in (via imports/exports) rather than the order the symbol flags happen to be stored in. It's basically normalising the order of the flags section, which isn't a disaster.

Repository:
  rL LLVM

https://reviews.llvm.org/D42117