[PATCH] D42305: [WebAssembly] Symbol changes #4c: import weak, LLD only

[Nicholas Wilson via Phabricator via llvm-commits]

ncw created this revision.
ncw added a reviewer: sbc100.
Herald added subscribers: llvm-commits, sunfish, aheejin, jgravelle-google, dschuff, jfb.

When https://reviews.llvm.org/D42105 was landed, a chunk from it was discarded.

This review re-commits that specific chunk, plus a test that exercises it.

Changes:

- When using `--emit-relocs` or `--relocatable`, we really do need to import undefined weak symbols, since relocations are generated against them.
- The `relocatable.ll` test has been updated with an import of a weak undefined symbol to illustrate the issue.

It's not possible to commit the test separately from the fix - without the fix, the test crashes!


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42305

Files:
  test/wasm/relocatable.ll
  wasm/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42305.130650.patch
Type: text/x-patch
Size: 10264 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180119/94b775d1/attachment-0001.bin>