[PATCH] D42297: [DebugInfo] Basic .debug_names dumping support

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

May I ask you to split out the renaming and the adding of the new functionality into separate patches? Having smaller incremental steps will make it easier for us to adapt our yet-to-be upstreamed code.

> In terms of sharing the implementation, I found the format of the two
>  tables sufficiently different to frustrate any attempts to have common
>  parsing or dumping code, so presently the implementations share just low
>  level code for formatting dwarf constants.

Seems fair. @JDevlieghere, do you agree with Pavel's assessment?



================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:26
 
-/// This implements the Apple accelerator table format, a precursor of the
-/// DWARF 5 accelerator table format.
-/// TODO: Factor out a common base class for both formats.
 class DWARFAcceleratorTable {
+protected:
----------------
We probably still want some comment here?


Repository:
  rL LLVM

https://reviews.llvm.org/D42297