[PATCH] D41439: [mips] Properly select abs and sqrt instructions

[Simon Dardis via Phabricator via llvm-commits]

sdardis added a comment.

This looks



================
Comment at: lib/Target/Mips/MicroMips32r6InstrInfo.td:1627-1630
+let AddedComplexity = 1 in {
+  def ABS_S_MMR6 : StdMMR6Rel, ABS_S_MMR6_ENC, ABS_S_MMR6_DESC, ISA_MICROMIPS32R6;
+  def ABS_D_MMR6 : StdMMR6Rel, ABS_D_MMR6_ENC, ABS_D_MMR6_DESC, ISA_MICROMIPS32R6;
+}
----------------
You can remove the definitions of these instructions from MicroMips32r6 as you have provided the FGR64 definitions in MicroMipsInstrFPU.td and the instructions share the same encodings.


================
Comment at: lib/Target/Mips/MicroMips32r6InstrInfo.td:1655-1660
+let AddedComplexity = 1 in {
+  def ASQRT_S_MMR6 : StdMMR6Rel, SQRT_S_MMR6_ENC, SQRT_S_MMR6_DESC,
+                     ISA_MICROMIPS32R6;
+  def ASQRT_D_MMR6 : StdMMR6Rel, SQRT_D_MMR6_ENC, SQRT_D_MMR6_DESC,
+                     ISA_MICROMIPS32R6;
+}
----------------
I've checked this again, you can remove the definition of these instructions from MicroMips32r6InstrInfo.td, as they share the same encoding as the original microMIPS instruction and you have provided the FGR64 definitions in MicroMipsInstrFPU.td.


https://reviews.llvm.org/D41439