[PATCH] D41297: [ThinLTO] Implement summary visualizer

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 added inline comments.


================
Comment at: lib/IR/ModuleSummaryIndex.cpp:297
+      defineExternalNode(OS, "  ", getValueInfo(E.Dst));
+      ModList.push_back(-1);
+    }
----------------
tejohnson wrote:
> might as well add continue at the end of this if body since the subsequent handling is for the non-empty ModList case.
Actually we add -1 to module list to draw an edge to an external node (like `printf` or `atoi` in the picture).  This edge is being drawn in the loop below. 


https://reviews.llvm.org/D41297