[PATCH] D42105: [WebAssembly] Symbol changes #4: export relocatable, LLD only

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 19:14:47 PST 2018


inglorion added inline comments.


================
Comment at: lld/trunk/wasm/Writer.cpp:67
+struct WasmExportEntry {
+  const Symbol *Symbol;
+  StringRef FieldName; // may not match the Symbol name
----------------
gcc seems unhappy with this declaration. It complains:

    llvm/tools/lld/wasm/Writer.cpp:67:17: error: declaration of ‘const lld::wasm::Symbol* {anonymous}::WasmExportEntry::Symbol’ [-fpermissive]
       const Symbol *Symbol;
                 ^
    In file included from llvm/tools/lld/wasm/Config.h:17:0,
                     from llvm/tools/lld/wasm/Writer.cpp:13:
    llvm/tools/lld/wasm/Symbols.h:27:7: error: changes meaning of ‘Symbol’ from ‘class lld::wasm::Symbol’ [-fpermissive]
     class Symbol {
           ^

I have put up D42278 to rename the field and stop the naming collision.


Repository:
  rL LLVM

https://reviews.llvm.org/D42105





More information about the llvm-commits mailing list