[PATCH] D37582: Remove pipeline dependencies on StackProtector

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 18:45:03 PST 2018


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

Ah nice, thanks for cleaning this up!
LGTM with nitpicks addressed:

- Add a "CodeGen: " prefix and a "; NFC" suffix to the commit title.



================
Comment at: include/llvm/CodeGen/MachineFrameInfo.h:91
+public:
+  /// SSPLayoutKind.  Stack Smashing Protection (SSP) rules require that
+  /// vulnerable stack allocations are located close the stack protector.
----------------
Don't repeat the enum name.


Repository:
  rL LLVM

https://reviews.llvm.org/D37582





More information about the llvm-commits mailing list