[PATCH] D42214: libcxx: Move Windows threading support into a .cpp file.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

> This prevents inlining, which might not be great.

It doesn't seem like a big problem to me. Many of these APIs will result in system calls, and the cost of not inlining is probably dwarfed by the cost of the system call.

> Also, IIRC, a CRITICAL_SECTION is actually a 40-byte sized struct, so replacing CRITICAL_SECTION with void * is gonna cause issues.

So it is. I'll fix that.


https://reviews.llvm.org/D42214