[PATCH] D42274: [Support] Remove the terminfo dependency and rely on TERM

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 17:27:43 PST 2018


phosek created this revision.
phosek added a reviewer: jyknight.
Herald added subscribers: llvm-commits, mgorny.

The current implementation of terminal color support that relies on
terminfo is broken and also introduces additional dependency. This
change removes this implementation and replaces it with a simpler
mechanism that detects the terminal color support by checking the value
of the TERM environment variable. This is what other GNU tools do as
well. If it's good enough for them, it's good enough for us too, and we
don't need to extra complexity and dependencies


Repository:
  rL LLVM

https://reviews.llvm.org/D42274

Files:
  CMakeLists.txt
  cmake/config-ix.cmake
  cmake/modules/LLVMConfig.cmake.in
  include/llvm/Config/config.h.cmake
  lib/Support/CMakeLists.txt
  lib/Support/Unix/Process.inc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42274.130524.patch
Type: text/x-patch
Size: 5496 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180119/50cd1187/attachment.bin>


More information about the llvm-commits mailing list