[PATCH] D42055: Fallback option for colorized output when terminfo isn't available

[Joerg Sonnenberger via Phabricator via llvm-commits]

joerg added a comment.

Do you see the comment just following the code? The patch completely violates that basic design principle. It would be perfectly sensible to hard-code a list of dumb terminals and explicitly default to no colors for them. The reverse (hard-coding a list and assuming it is fine for everything else) is not.


Repository:
  rL LLVM

https://reviews.llvm.org/D42055