[PATCH] D42105: [WebAssembly] Symbol changes #4: export relocatable, LLD only

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 15:22:32 PST 2018


sbc100 added inline comments.


================
Comment at: wasm/Writer.cpp:600
   for (Symbol *Sym : Symtab->getSymbols()) {
-    if (!Sym->isUndefined() || Sym->isWeak())
+    if (!Sym->isUndefined() || (Sym->isWeak() && !Config->EmitRelocs))
       continue;
----------------
I think this is unrelated?  At least all the tests still pass without this line.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42105





More information about the llvm-commits mailing list