[PATCH] D42205: [X86] Add intrinsic support for the RDPID instruction

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 14:26:32 PST 2018


RKSimon added inline comments.


================
Comment at: lib/Support/Host.cpp:1260
+
+  Features["ibt"] = HasLeaf7 && ((EDX >> 20) & 1);
 
----------------
craig.topper wrote:
> RKSimon wrote:
> > Revert spacing change to keep = aligned.
> I unaligned it because its checking EDX and the lines above are checking ECX. And the EBX lines above that have a different alignment.
> 
> While not paying attention previously I accidentally put the ibt line with the ECX lines as you can see in the before here. I was trying to discourage accidentally doing that again.
OK fair enough - LGTM


https://reviews.llvm.org/D42205





More information about the llvm-commits mailing list