[PATCH] D42082: Add DWARF for discriminated unions
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 18 14:22:40 PST 2018
probinson added a comment.
In https://reviews.llvm.org/D42082#980534, @tromey wrote:
> Another thing to consider is that this is really just the first patch in a larger project. There are other things in Rust that will require new debuginfo. Some of these can be mapped to existing DWARF (e.g., traits can probably use `DW_TAG_interface` pretty comfortably); but some cannot (e.g., the distinction between tuples and structs).
Any new DWARF tags/attributes for Rust should be distinct enough from existing features to be proposed as new features for DWARF 6. Enums-with-data really do look enough like variant records that I think a new Rust_enum would be hard to justify. I don't know Rust at all (other than recent googling about enums so I can heckle you in this review) so we'll take each one as it comes. Just because one Rust feature will require a new tag doesn't mean all Rust features should get new tags.
Repository:
rL LLVM
https://reviews.llvm.org/D42082
More information about the llvm-commits
mailing list