[PATCH] D41827: [DEBUG] Initial adaptation of NVPTX target for debug info emission.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 14:18:00 PST 2018


tra added a comment.

LGTM for NVPTX side. Please wait for @echristo's LGTM in case he has any comments.



================
Comment at: lib/Target/NVPTX/NVPTXAsmPrinter.cpp:477
+  // Emit open brace for function body.
   OutStreamer->EmitRawText(StringRef("{\n"));
   setAndEmitFunctionVirtualRegisters(*MF);
----------------
Please add a comment here that the closing brace is emitted at the end of NVPTXAsmPrinter::runOnMacheineFunction(). 


Repository:
  rL LLVM

https://reviews.llvm.org/D41827





More information about the llvm-commits mailing list