[PATCH] D42224: Don't assume a null GV is local for ELF and MachO

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 14:16:34 PST 2018


rnk added inline comments.


================
Comment at: llvm/lib/Target/TargetMachine.cpp:140
 
+  // If GV is null we know that this is a call to an intrinsic. For ELF and
+  // MachO we don't need to assume those are local since the liker can trivially
----------------
Do we ever synthesize references to globals? Those will need a GOT reference if the global turns out to be non-local.


https://reviews.llvm.org/D42224





More information about the llvm-commits mailing list