[PATCH] D42128: [X86] Extend load-op-store fusion merge to ADC/SBB.

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 11:23:38 PST 2018


niravd added a comment.

> Unless I'm crazy the entirety of addcarry2.ll already passes on trunk. I think we hit regular isel patterns unless the carry out of the ADC/SBB is used.

You are correct these case are already handled, but they're now being matched here so this at least shows we're mimicking the default instruction selection .

I've found a valid test case for generating ADCs of with the same length as the address size but not the smaller ones. I'll update with those test for 32 and 64. No luck with SBB immediate tests though. I'll update the patch presently.


Repository:
  rL LLVM

https://reviews.llvm.org/D42128





More information about the llvm-commits mailing list