[PATCH] D42247: [Dominators] Fix some edge cases for PostDomTree updating

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 11:20:22 PST 2018


kuhar accepted this revision.
kuhar added a comment.
This revision is now accepted and ready to land.

Looks good overall, thanks for catching and fixing that.



================
Comment at: unittests/IR/DominatorTreeBatchUpdatesTest.cpp:295
+      {"7", "8"}, {"8", "8"}, {"9", "10"}, {"9", "11"}, {"10", "13"}, {"11", "13"},
+      {"12", "15"}, {"12", "13"}, {"15", "13"}, {"13", "2"}, {"2", "3"}, {"13", "14"}};
+
----------------
I think it's easier to read these tests when you order them by left nodes -- then it reads like IR, where for each BB you have some number of successors.
I'd even make sense to have them one line per each block, like:
```
1 3
3 4, 3 4
4 14
6 7, 6 9
...
```


https://reviews.llvm.org/D42247





More information about the llvm-commits mailing list