[PATCH] D42234: [ADT] Add PropagateConst from LFTS2

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 11:09:57 PST 2018


Not necessarily conflate, but at least understand where this is going.

(looks like it could use some more tests? At least for get_underlying?
Haven't looked carefully at the rest of the interface to check that it's
tested - I imagine libc++ has comprehensive test coverage for this?)

On Thu, Jan 18, 2018 at 10:42 AM Jonathan B Coe via Phabricator <
reviews at reviews.llvm.org> wrote:

> jbcoe added a comment.
>
> I was planning on deferring application (some instances of unique_ptr
> member data) to a follow-up patch. Would you prefer that I conflate them?
>
>
> https://reviews.llvm.org/D42234
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180118/e85561a0/attachment.html>


More information about the llvm-commits mailing list