[PATCH] D42175: [AArch64][GlobalISel] Add isel support for global values in the large code model

[Roger Ferrer Ibanez via Phabricator via llvm-commits]

rogfer01 accepted this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.

Hi @aemerson thanks a lot for the prompt fix.

I've run the internal tests that flagged this issue with a patched toolchain and they pass after this.

This change LGTM except for a minor issue with C++. No need to re-review.



================
Comment at: lib/Target/AArch64/AArch64InstructionSelector.cpp:885
+      auto BuildMovK = [&](unsigned SrcReg, unsigned char Flags,
+                           unsigned Offset, unsigned ForceDstReg = 0) {
+        unsigned DstReg =
----------------
C++11 compilers in pedantic mode will diagnose this default argument so perhaps you want to remove it, however this is valid C++14.


Repository:
  rL LLVM

https://reviews.llvm.org/D42175