[PATCH] D42246: [NFC] Generalize DwarfAccelTable

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere marked 6 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfAccelTable.h:169
 #ifndef NDEBUG
     void print(raw_ostream &OS) const {
+      OS << "  Offset: " << Die->getOffset() << "\n";
----------------
aprantl wrote:
> JDevlieghere wrote:
> > aprantl wrote:
> > > Is this code not needed for dwarfdump?
> > What do you mean exactly?
> The print function is asserts (!NDEBUG) only; I was wondering if we don't want to print this in llvm-dwarfdump ever.
Right. This code doesn't actually read any data so I don't think it would benefit dwarfdump unless we manage to unify this with its counterpart in DebugInfo. 


Repository:
  rL LLVM

https://reviews.llvm.org/D42246