[PATCH] D42233: [WebAssembly] Better support for WASM Object format

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lib/Object/WasmObjectFile.cpp:1058
-bool WasmObjectFile::isSectionBitcode(DataRefImpl Sec) const { return false; }
-
 relocation_iterator WasmObjectFile::section_rel_begin(DataRefImpl Ref) const {
----------------
This seems reasonable, and could even be a separate change that could land right away if your prefer.


================
Comment at: lib/Object/WasmObjectFile.cpp:1149
   Ref.d.a = 0;
+  Ref.d.b = 0;
   return section_iterator(SectionRef(Ref, this));
----------------
Should do this for section_end() too? and symbol_begin()/end() too?

Is there a particular motivation for this? I someone reading this value somewhere?


Repository:
  rL LLVM

https://reviews.llvm.org/D42233