[PATCH] D42246: [NFC] Generalize DwarfAccelTable

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 09:56:31 PST 2018


aprantl added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfAccelTable.h:169
 #ifndef NDEBUG
     void print(raw_ostream &OS) const {
+      OS << "  Offset: " << Die->getOffset() << "\n";
----------------
JDevlieghere wrote:
> aprantl wrote:
> > Is this code not needed for dwarfdump?
> What do you mean exactly?
The print function is asserts (!NDEBUG) only; I was wondering if we don't want to print this in llvm-dwarfdump ever.


Repository:
  rL LLVM

https://reviews.llvm.org/D42246





More information about the llvm-commits mailing list