[PATCH] D42246: [NFC] Generalize DwarfAccelTable

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 09:31:20 PST 2018


labath added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfAccelTable.h:163
 public:
   struct HashDataContents {
     const DIE *Die;   // Offsets
----------------
Do we need the HashDataContents struct if it is just a `DIE*` wrapper? I am not sure if there is anything that we would want to emit that cannot extracted  from a DIE pointer by a suitable DataForAtomFunction callback...


Repository:
  rL LLVM

https://reviews.llvm.org/D42246





More information about the llvm-commits mailing list