[PATCH] D42239: [CodeGen] Print RegClasses on MI in verbose mode

[Daniel Sanders via Phabricator via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a couple comment nits



================
Comment at: include/llvm/CodeGen/MachineOperand.h:275
+  /// prints extra information that can be easily inferred when the whole
+  /// function is available, but is more pleasant to debug/read.
   /// \param ShouldPrintRegisterTies - whether we want to print register ties.
----------------
I'd go with 'but not when a fragment of the function is printed' or something to that effect to make it clear that the information is not available when you aren't looking at the whole function


================
Comment at: lib/CodeGen/MachineFunction.cpp:525
     OS << '\n';
-    BB.print(OS, MST, Indexes);
+    // If we print the whole function, don't print any verbose information.
+    BB.print(OS, MST, Indexes, /*IsVerbose=*/false);
----------------
... since that information is already present.


https://reviews.llvm.org/D42239