[PATCH] D41617: [AMDGPU] Add HW_REG_SH_MEM_BASES symbolic name for s_getreg_b32

[Artem Tamazov via Phabricator via llvm-commits]

artem.tamazov added a comment.

In https://reviews.llvm.org/D41617#977175, @rampitec wrote:

> I believe the source of inconsistency is the original definition of ID_SYMBOLIC_LAST_, which does not point to a last value in the enum, but a last + 1. This can be changed in a separate patch.


Yes, the names are not consistent with an original idea. However, I recommend renaming `*FIRST*`/`*LAST*` to `*BEGIN*`/`*END*` to better express iterator-like semantics. Thanks for catching this.


Repository:
  rL LLVM

https://reviews.llvm.org/D41617