[PATCH] D41653: [RISCV] Initial porting GlobalISel

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 03:54:36 PST 2018


asb added a comment.
Herald added a subscriber: niosHD.

Hi Leslie, this patch includes rather a lot which makes it somewhat hard to review - i.e. you're doing call handling, loads/store selection, selection for some ALU ops, FPR32/FPR64 regs + fcmp, and there aren't any tests attached that check this all works.

Do you think it might make sense to start with something more minimal, perhaps stripping this back to doing the bare minimum for a simple function - e.g. a ret void no-op, or a function that adds two arguments. I think that would make it much easier to review and move this forwards. Many thanks for your work here.


Repository:
  rL LLVM

https://reviews.llvm.org/D41653





More information about the llvm-commits mailing list