[PATCH] D42156: Force lit to execute the ASan and TSan tests on iOS devices sequentially

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 20:18:28 PST 2018


delcypher updated this revision to Diff 130355.
delcypher added a comment.

Address first round of feedback.


https://reviews.llvm.org/D42156

Files:
  test/asan/lit.cfg
  test/lit.common.cfg
  test/tsan/lit.cfg


Index: test/tsan/lit.cfg
===================================================================
--- test/tsan/lit.cfg
+++ test/tsan/lit.cfg
@@ -85,5 +85,8 @@
 if config.android:
   config.unsupported = True
 
-if config.host_os == 'Darwin' and config.target_arch in ["x86_64", "x86_64h"]:
-  config.parallelism_group = "darwin-64bit-sanitizer"
+if config.host_os == 'Darwin':
+  if config.target_arch in ["x86_64", "x86_64h"]:
+    config.parallelism_group = "darwin-64bit-sanitizer"
+  elif config.ios:
+    config.parallelism_group = "darwin-ios-device-sanitizer"
Index: test/lit.common.cfg
===================================================================
--- test/lit.common.cfg
+++ test/lit.common.cfg
@@ -291,6 +291,14 @@
 if platform.system() == 'Darwin':
   lit_config.parallelism_groups["darwin-64bit-sanitizer"] = 3
 
+# The current implementation of the tools in sanitizer_common/ios_comamnds
+# do not support parallel execution so force sequential execution of the
+# tests on iOS devices.
+if config.host_os == 'Darwin' and config.ios:
+  lit_config.warning("iOS device test cases being run sequentially")
+  lit_config.parallelism_groups["darwin-ios-device-sanitizer"] = 1
+
+
 if config.host_os == 'Darwin':
   config.substitutions.append( ("%ld_flags_rpath_exe", '-Wl,-rpath, at executable_path/ %dynamiclib') )
   config.substitutions.append( ("%ld_flags_rpath_so", '-install_name @rpath/`basename %dynamiclib`') )
Index: test/asan/lit.cfg
===================================================================
--- test/asan/lit.cfg
+++ test/asan/lit.cfg
@@ -212,5 +212,8 @@
 if config.host_os not in ['Linux', 'Darwin', 'FreeBSD', 'SunOS', 'Windows']:
   config.unsupported = True
 
-if config.host_os == 'Darwin' and config.target_arch in ["x86_64", "x86_64h"]:
-  config.parallelism_group = "darwin-64bit-sanitizer"
+if config.host_os == 'Darwin':
+  if config.target_arch in ["x86_64", "x86_64h"]:
+    config.parallelism_group = "darwin-64bit-sanitizer"
+  elif config.ios:
+    config.parallelism_group = "darwin-ios-device-sanitizer"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42156.130355.patch
Type: text/x-patch
Size: 2052 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180118/6181443d/attachment.bin>


More information about the llvm-commits mailing list