[PATCH] D42021: [DWARF] v5 implementation of string offsets tables - producer side

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp updated this revision to Diff 130344.
wolfgangp marked 8 inline comments as done.
wolfgangp added a comment.

Addressed most of David's review comments and commented on the ones I didn't address.

Changed the test cases to use enums instead of structs. This reduced their size. Added more comments and tightened them up a bit.

Fixed a couple of bugs:

- strx3 handling was missing in couple of places.
- compilations without a .debug_str section still generated a .debug_str_offsets section (a header). They don't any more.


https://reviews.llvm.org/D42021

Files:
  lib/CodeGen/AsmPrinter/DIE.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.h
  lib/CodeGen/AsmPrinter/DwarfFile.cpp
  lib/CodeGen/AsmPrinter/DwarfFile.h
  lib/CodeGen/AsmPrinter/DwarfStringPool.cpp
  lib/CodeGen/AsmPrinter/DwarfStringPool.h
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfUnit.h
  test/DebugInfo/Generic/string-offsets-form.ll
  test/DebugInfo/Generic/string-offsets-multiple-cus.ll
  test/DebugInfo/Generic/string-offsets-table.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42021.130344.patch
Type: text/x-patch
Size: 47803 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180118/2fd062a2/attachment.bin>