[PATCH] D42087: [DSE] Improve handling of noop stores exposed after dead interfering stores are removed

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:1089
+      // Noops can be removed across blocks, even with no local memdef
+      EliminateNoop();
       continue;
----------------
Could you just eliminate this entire if statement?  The condition is the same as the while loop's condition.


================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:1098
+    if (!Loc.Ptr) {
+      EliminateNoop();
       continue;
----------------
I don't think EliminateNoop can actually do anything useful in this case; getLocForWrite never fails for store instructions.


https://reviews.llvm.org/D42087