[PATCH] D42216: Use New Module Metadata String "AvoidPLT" to avoid calls via PLT

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

AvoidPLT doesn't seem like the best name. A more affirmative name like "RtlibUseGOT" might be better.



================
Comment at: lib/IR/Module.cpp:518
+    return true;
+
+  return false;
----------------
Maybe this should check Val->getZExtValue for a non-zero value.


================
Comment at: test/CodeGen/X86/no-plt.ll:14
+}
+
+define i32 @main() #1 {
----------------
Can you test a few other RTLIB functions like i128 multiply and memset, just for generality?


https://reviews.llvm.org/D42216