[PATCH] D42206: If kevent() is interrupted by signal (or is being debugged) and we get EINTR, retry

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 16:28:26 PST 2018


vsk added a comment.

In https://reviews.llvm.org/D42206#979607, @clayborg wrote:

> Are we going to test each unix call that can fail with EINTR? Seems a bit overkill.


I think going forward, we should test all functional changes unless it really is prohibitively expensive to do so. Useful changes like this shouldn't be lost to accidental/unrelated commits, and having a regression test is a good way to ensure that.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42206





More information about the llvm-commits mailing list