[PATCH] D40425: Extending CFGPrinter and CallPrinter with Heat Colors

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 14:46:39 PST 2018


sfertile added inline comments.


================
Comment at: lib/Analysis/CallPrinter.cpp:287
 
-struct CallGraphDOTPrinter : public DOTGraphTraitsModulePrinter<
-                              CallGraphWrapperPass, true, CallGraph *,
-                              AnalysisCallGraphWrapperPassTraits> {
+void CallGraphViewer::getAnalysisUsage(AnalysisUsage &AU) const {
+  ModulePass::getAnalysisUsage(AU);
----------------
this should be marked as 'override'


================
Comment at: lib/Analysis/CallPrinter.cpp:319
 
+void CallGraphDOTPrinter::getAnalysisUsage(AnalysisUsage &AU) const {
+  ModulePass::getAnalysisUsage(AU);
----------------
Should have 'override' here as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D40425





More information about the llvm-commits mailing list