[PATCH] D41705: Place undefined globals in .bss instead of .data

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 14:11:19 PST 2018


efriedma added inline comments.


================
Comment at: lib/Target/TargetLoweringObjectFile.cpp:63
+    return false;
+  for (unsigned i = 0, e = C->getNumOperands(); i != e; ++i) {
+    if (!isNullOrUndef(cast<Constant>(C->getOperand(i))))
----------------
Maybe "for (auto Operand : C->operand_values())"?


https://reviews.llvm.org/D41705





More information about the llvm-commits mailing list