[PATCH] D42188: [LLD][PDB] Implement FIXME: Warn on missing TypeServer PDB rather than error

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 13:37:11 PST 2018


rnk added inline comments.


================
Comment at: COFF/PDB.cpp:768-769
+  if (!IndexMapResult) {
+    warn("Type server PDB was not found: " +
+         toString(std::move(IndexMapResult.takeError())));
+    return;
----------------
This is the MSVC warning text:
  t.obj : warning LNK4099: PDB 'vc140.pdb' was not found with 't.obj' or at 'C:\src\llvm-project\build\vc140.pdb'; linking object as if no debug info

I think it might be worth including the .obj path or at least the basename and mentioning that we're ignoring its debug info. Maybe something like:
  warning: Type server PDB foo.pdb was not found, ignoring debug info from foo.obj


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42188





More information about the llvm-commits mailing list