[PATCH] D33753: [libcxxabi] Add back HandleLLVMOptions for out of tree builds

Wed Jan 17 12:23:45 PST 2018

martell added a comment.

In https://reviews.llvm.org/D33753#975343, @sbc100 wrote:

> My problem is that HandleLLVMOptions seems to add a lot of compiler and system check.... seemingly more than are required to build libcxxabi.     It seems like by including this line we are maybe needlessly restricting the set of compilers/environments on which it can be built.

Hey Simon, this was my issue also, In https://reviews.llvm.org/rL304374 I did a refactor on the cmake usage in libcxxabi.
I removed `include(HandleLLVMOptions OPTIONAL)` which made the change a FC rather then a NFC so I re added this line.
Eric said that this is still needed for out of tree builds, beyond that I don't know any more details as I have never used llvm in this way.

Repository:
  rL LLVM

https://reviews.llvm.org/D33753