[PATCH] D41993: [ELF] - Change shift2 constant of GNU_HASH from 6->11.

[Rafael Avila de Espindola via llvm-commits]

Rui Ueyama <ruiu at google.com> writes:

> That was my misunderstanding. Sorry for the false alarm.
>
> That said, I don't think this patch makes much sense. There's no theory
> behind it to explain why this could make things faster (it shouldn't as
> long as the hash function generates evenly distributed hash value). I think
> what we should do is
>
> 1. first, verify that our bloom filter is really correct by taking a look
> at the output binary carefully, because even if the bloom filter is wrong,
> that doesn't cause any correctness issue, but instead it just makes things
> slower, and then

I don't think that is correct in general. Consider a bloom filter of all
0s. With that the dynamic linker would not try to lookup any symbol in
that dso.

Cheers,
Rafael