[PATCH] D41993: [ELF] - Change shift2 constant of GNU_HASH from 6->11.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 08:12:51 PST 2018


Rui Ueyama <ruiu at google.com> writes:

> I feel like this change looks a bit too arbitrary. If we can prove that it
> is in general an improvement, I'm fine with this change, but even George's
> experiment shows that 11 may not be an optimal number.
>
> Probably what we should do is to try different shift2 numbers to see if
> which one yields the best result on the fly. I'll try to see if this isn't
> too slow.

Note that his computed score doesn't correlate with performance in all
cases. In particular I got bad results with 1, but that has a high
score.

Cheers,
Rafael


More information about the llvm-commits mailing list