[PATCH] D42142: Adding Live-range reordering for Polly

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

@bollu Alex added the code duplication because I suggested him to do so. IMHO the live-range reordering should not depend on ppcg at all. ppcg is not written as a library so in terms of software quality, we should not use it as one. On the llvm mailing list we currently discuss the inclusion of isl. I don't think we will not do the same for ppcg, meaning that if live-range reordering depends on it, we would have to remove it again should Polly be included into LLVM main.



================
Comment at: lib/Transform/ScheduleOptimizer.cpp:1923-1924
+
+PPCGWrapperLRR ppcgObj;
+ppcg_scop *ps = NULL;
+void FreePPCGObjects() {
----------------
bollu wrote:
> I am wary of global mutable state. Can we try to refactor this so that we don't need it? 
Agreed, we should not use global state if avoidable. It is problematic if Polly is used as a library.


Repository:
  rPLO Polly

https://reviews.llvm.org/D42142