[PATCH] D42075: [WebAssembly] Symbol changes #1, LLVM

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added a comment.

In https://reviews.llvm.org/D42075#977374, @sbc100 wrote:

> I think dropping the debug names from the symbol table seems like a good idea.
>  I'm not so sure about dropping the the imports from the name section.   It seems at least like a separate change.
>  I like added requirement on the section ordering, although I'd prefer a more explicit way to check for it.
>
> What do you think about dropping the name section completely from the compiler output?  If the compiler output is meant mainly as a linker input perhaps we don't need a names section at all (since its arguably redundant in the face of the symbol table stuff).


I agree with dropping the names section completely in WasmObjectWriter. That seems to me like a separate change - could I do that as another patch, after this?

You're right I shouldn't have sneaked in the change to drop names for imports. It's there from a previous version to the patch, but actually now imports could stay. In favour of dropping their names: a) it's useless file bloat; b) neither the Chrome devtools disassembler nor binaryen/wasm-dis make use of the names for imports, although I suppose they could in future. For the time being though I've reverted it.


Repository:
  rL LLVM

https://reviews.llvm.org/D42075