[PATCH] D42080: [WebAssembly] Symbol changes #2: Table relocs, LLVM

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:608
+    case wasm::R_WEBASSEMBLY_TABLE_INDEX_SLEB: {
+      uint32_t TableIndex = getProvisionalTableIndex(RelEntry);
+      WritePatchableSLEB(Stream, TableIndex, Offset);
----------------
sbc100 wrote:
> Can you just use getRelocationIndexValue() here and drop getProvisionalTableIndex() completely?
You're right that getProvisionalTableIndex doesn't do much at the moment...

The reason I kept the existing behaviour is to avoid changing the test output for the ELEM section in this commit. The next review (#3) then modifies getProvisionalTableIndex further. So this is just an intermediate stage to keep each commit in the chain from doing too many changes at once.


Repository:
  rL LLVM

https://reviews.llvm.org/D42080