[PATCH] D42148: [CodeView] Speed up type iteration

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 16 17:18:23 PST 2018


rnk added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CVRecord.h:67
+  while (!StreamBuffer.empty()) {
+    const RecordPrefix *Prefix = (const RecordPrefix *)StreamBuffer.data();
+
----------------
This needs to be bounds checked. That's why we came up with that consumeObject pattern, right?


https://reviews.llvm.org/D42148





More information about the llvm-commits mailing list