[PATCH] D42064: Add new NetBSD interceptors: getgrouplist(3) & getgroupmembership(3)

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

Tests?



================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:6476
+  if (groups && ngroups)
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, groups, sizeof(*groups) * (*ngroups));
+  return res;
----------------
you need COMMON_INTERCEPTOR_WRITE_RANGE(ctx, ngroups... as well


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:6478
+  return res;
+}
+INTERCEPTOR(int, getgroupmembership, char *name, u32 basegid, u32 *groups, int maxgrp, int *ngroups) {
----------------
add empty line between interceptors


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:6488
+  if (groups && ngroups)
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, groups, sizeof(*groups) * (*ngroups));
+  return res;
----------------
same about ngroups


Repository:
  rL LLVM

https://reviews.llvm.org/D42064