[PATCH] D42123: Derive GEP index type from Data Layout

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 16 17:16:02 PST 2018


craig.topper added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:1887
+          assert(Idx->getType() == DL.getIndexType(GEP.getType()) &&
                  "Index not cast to pointer width?");
 
----------------
Should this assert message be updated since it not guaranteed to be pointer width now?


================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:1927
+          assert(Idx->getType() == DL.getIndexType(GEP.getType()) &&
                  "Index not cast to pointer width?");
 
----------------
Same with this assert.


Repository:
  rL LLVM

https://reviews.llvm.org/D42123





More information about the llvm-commits mailing list