[PATCH] D42134: [lnt] Fix global status page being unable to load due to crash

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 16 16:08:20 PST 2018


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM.

And out of interest: Are you actually using the /global_status page? `global_status` (and `summary_report` for that matter) is a feature/page that doesn't appear to be used by anyone in our company and it has zero test coverage. Hence the two pages bitrot and are broken a lot. I would love to just remove them (the alternative would be to create proper tests, but I'm not even sure about the typical usecase for those two pages and don't want to spend time creating tests for something that seems unused...)


Repository:
  rL LLVM

https://reviews.llvm.org/D42134





More information about the llvm-commits mailing list