[PATCH] D42030: [WebAssembly] Define __heap_base global

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: wasm/Writer.cpp:38
 static constexpr int kStackAlignment = 16;
+static constexpr int kHeapAlignment = 4096;
 
----------------
dschuff wrote:
> Why 4096? Since wasm pages are 16k, is there some particular reason for it to be this as opposed to something else?
No really any good reason...  should we just make it 16-byte aligned like the stack?  In which case there is not need to do any more alignedment since the heap will follow the stack region which is already 16-byte aligned.

Incidentally our musl limits.h currently defines PAGE_SIZE to 4k.. should we change it to 16k?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42030